Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update framework for the use of real/imag #146

Merged
merged 29 commits into from
Feb 21, 2023
Merged

Update framework for the use of real/imag #146

merged 29 commits into from
Feb 21, 2023

Conversation

FeGeyer
Copy link
Member

@FeGeyer FeGeyer commented Feb 17, 2023 •
edited
Loading

Major changes:

  • Add normalization callback with two different techniques
  • Update plotting routines for real/imag images
  • Update use of ms-ssim
  • Update evaluate_area and evaluate_ms_ssim for half images
  • Add evaluate_ms_ssim for sampled images

Small changes:

  • Add the model name to predictions and sampling file
  • Delete unnecessary pad_unsqueeze function
  • Add amp_phase keyword to sample_images
  • Fix deprecation warning in sampling.py
  • Add image size to test_evaluation.py routines

To-Do

  • Add loading of normalization factors
  • Add automatic rescaling for evaluation routines

FeGeyer added 24 commits February 9, 2023 09:26
@FeGeyer
Modify functions to work for real_imag
5516084
@FeGeyer
Dont use hardtanh anymore
26ef7a4
@FeGeyer
Fix some tests
bdf888f
@FeGeyer
Add area sampled to script
c6c96ef
@FeGeyer
Change plotting for real imag
afeb848
@FeGeyer
Added creation and saving of normalization factors
1a56897
@FeGeyer
Execute normalize only for training
b8d5791
@FeGeyer
Add model_name to prediction file
7fe50b6
@FeGeyer
Revert use of sampling functions
fcb54c8
@FeGeyer
Update plot titles
a2cc2ce
@FeGeyer
Fix tests
4c91914
@FeGeyer
Update evaluation functions for half images
d66a760
@FeGeyer
Add docstring
03909b0
@FeGeyer
Fix ms ssim plotting
b695f24
@FeGeyer
Add normalization for area and ms ssim
cecc575
@FeGeyer
Implement another normalize method
d6af92b
@FeGeyer
Add keyword
9ba4a82
@FeGeyer
Revert changes
31ba0e6
@FeGeyer
Add correct keyword
3694da1
@FeGeyer
Fix saving
a27c2e3
@FeGeyer
Add img_size to tests
b88de69
@FeGeyer
Fix deprecation warning
aec2fc3
@FeGeyer
Fix for the tests to run
6df9175
@FeGeyer
Revert hardcoded inverse normalisation
a1df787
@FeGeyer FeGeyer added enhancement New feature or request fix Fixes an issue or problem labels Feb 17, 2023
@FeGeyer FeGeyer requested a review from Kevin2 February 17, 2023 14:57
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023 •
edited
Loading

Codecov Report

Base: 47.59% // Head: 47.37% // Decreases project coverage by -0.23% ⚠️

Coverage data is based on head (ef46a80) compared to base (1561e49).
Patch coverage: 36.76% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
- Coverage   47.59%   47.37%   -0.23%     
==========================================
  Files          32       32              
  Lines        3494     3635     +141     
==========================================
+ Hits         1663     1722      +59     
- Misses       1831     1913      +82
Impacted Files Coverage Δ
radionets/dl_framework/architectures/res_exp.py 34.86% <0.00%> (+0.31%) ⬆️
radionets/evaluation/plotting.py 35.09% <0.00%> (-0.60%) ⬇️
radionets/dl_framework/callbacks.py 43.12% <19.23%> (-3.36%) ⬇️
radionets/evaluation/train_inspection.py 48.81% <31.46%> (-2.29%) ⬇️
radionets/dl_framework/model.py 54.14% <42.85%> (-0.53%) ⬇️
radionets/dl_framework/learner.py 85.29% <50.00%> (-2.21%) ⬇️
radionets/dl_training/scripts/start_training.py 57.33% <50.00%> (-0.21%) ⬇️
radionets/evaluation/utils.py 65.68% <52.00%> (-0.87%) ⬇️
radionets/dl_training/utils.py 83.15% <100.00%> (+5.38%) ⬆️
radionets/simulations/sampling.py 77.14% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FeGeyer FeGeyer merged commit 70c89ef into main Feb 21, 2023
@FeGeyer FeGeyer deleted the real_imag branch February 21, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kevin2 Kevin2 Kevin2 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request fix Fixes an issue or problem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FeGeyer @codecov-commenter @Kevin2